shuwenwei commented on PR #17975: URL: https://github.com/apache/iotdb/pull/17975#issuecomment-4737209821
I have one concern about the new hot-reload behavior for `heartbeat_interval_in_ms`. The PR correctly reschedules `HeartbeatService`, `StatisticsService`, `EventService`, and `RetryFailedTasksThread` when the interval changes. However, the Phi failure detector in `AbstractLoadCache` is constructed with `CONF.getHeartbeatIntervalInMs() * 200_000L`, so existing load caches may still keep the detector parameters derived from the old heartbeat interval after hot reload. Could you confirm whether the failure detector threshold is expected to follow `heartbeat_interval_in_ms` hot reload as well? If yes, we probably need to rebuild/update the existing load-cache failure detectors when the heartbeat interval changes, or add a test/clarification showing that only the scheduling interval is intended to be hot-reloaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
