CRZbulabula commented on PR #17975: URL: https://github.com/apache/iotdb/pull/17975#issuecomment-4738573162
Thanks for the detailed review. I pushed `fecde7f229` to address the remaining issues. What changed: - Failure detector behavior: no further code change in this commit. As clarified in `2e673122cc`, failure detector thresholds are intentionally restart-only for this PR and now use the startup heartbeat interval snapshot. Hot reload only reschedules the heartbeat-related services. - Rejected hot reload values: fixed the applied-property update ordering in both ConfigNode and DataNode so `show configuration` is only updated after a successful hot reload. I also fixed `ConfigManager.setConfiguration` to stop immediately when the local ConfigNode rejects a cluster-wide hot reload, so invalid values are not propagated to DataNodes or other ConfigNodes. - Region-per-node parsing: preserved compatibility for integer-compatible decimal strings such as `2.0`, while rejecting non-integer decimals such as `1.9` instead of truncating them. Added/updated IT coverage in `IoTDBSetConfigurationIT` for: - rejected `heartbeat_interval_in_ms=-1` not polluting ConfigNode/DataNode `show configuration`; - `schema_region_per_data_node` / `data_region_per_data_node` accepting `2.0` and rejecting `1.9`. Verified with: - `mvn spotless:apply -pl iotdb-core/confignode,iotdb-core/datanode` - `mvn spotless:apply -pl integration-test -P with-integration-tests` - `mvn compile -pl iotdb-core/confignode,iotdb-core/datanode -DskipTests -DskipUTs` - `mvn verify -DskipUTs -Dit.test=IoTDBSetConfigurationIT#testRejectedHotReloadDoesNotUpdateAppliedConfiguration+testHotReloadRegionGroupExtensionConfiguration -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -Drat.skip=true -pl integration-test -am -P with-integration-tests` - `git diff --check` Note: the same focused IT without `-Drat.skip=true` was blocked locally by an unrelated `.claude/scheduled_tasks.lock` RAT violation before tests started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
