CRZbulabula commented on PR #17975: URL: https://github.com/apache/iotdb/pull/17975#issuecomment-4737292968
Thanks @shuwenwei, confirmed that the failure detector threshold is not intended to follow `heartbeat_interval_in_ms` hot reload in this PR. The hot reload path only reschedules heartbeat-related services. I pushed a follow-up commit (`2e673122cc`) to make this explicit and avoid partial behavior: ConfigNode now keeps a startup heartbeat-interval snapshot for failure detector initialization, and `AbstractLoadCache` / `TopologyService` use that snapshot instead of the hot-reloaded heartbeat interval. Existing detectors are not rebuilt, and newly-created detectors after hot reload still use the startup value. Verified with: - `mvn spotless:apply -pl iotdb-core/confignode` - `mvn compile -pl iotdb-core/confignode -DskipTests -DskipUTs` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
