Caideyipi commented on code in PR #17665:
URL: https://github.com/apache/iotdb/pull/17665#discussion_r3449708423
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/schema/PipeSchemaRegionSinkMetrics.java:
##########
@@ -72,6 +74,38 @@ private void createRate(final String taskID) {
String.valueOf(connector.getCreationTime())));
}
+ private void createHistogram(final String taskID) {
+ final PipeSinkSubtask connector = connectorMap.get(taskID);
+
+ final Histogram schemaBatchSizeHistogram =
+ metricService.getOrCreateHistogram(
+ Metric.PIPE_SCHEMA_BATCH_SIZE.toString(),
+ MetricLevel.IMPORTANT,
+ Tag.NAME.toString(),
+ connector.getAttributeSortedString(),
+ Tag.CREATION_TIME.toString(),
+ String.valueOf(connector.getCreationTime()));
+ connector.setTabletBatchSizeHistogram(schemaBatchSizeHistogram);
Review Comment:
Addressed in f2e6bf9c13a. Added schema-specific setters on
PipeSinkSubtask/IoTDBSink and changed schema metrics to call
setSchemaBatchSizeHistogram/setSchemaBatchTimeIntervalHistogram, so
PIPE_SCHEMA_BATCH_SIZE no longer goes through tablet batch metric setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
