Caideyipi commented on code in PR #17665:
URL: https://github.com/apache/iotdb/pull/17665#discussion_r3449711679
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/airgap/IoTDBSchemaRegionAirGapSink.java:
##########
@@ -110,21 +185,39 @@ private void doTransfer(
final AirGapSocket socket,
final PipeSchemaRegionWritePlanEvent pipeSchemaRegionWritePlanEvent)
throws PipeException, IOException {
- if (!send(
+ doTransfer(
+ socket,
+ pipeSchemaRegionWritePlanEvent.getPlanNode(),
pipeSchemaRegionWritePlanEvent.getPipeName(),
pipeSchemaRegionWritePlanEvent.getCreationTime(),
- socket,
- PipeTransferPlanNodeReq.toTPipeTransferBytes(
- pipeSchemaRegionWritePlanEvent.getPlanNode()))) {
+ pipeSchemaRegionWritePlanEvent.toString());
+ }
+
+ private void doTransfer(
+ final AirGapSocket socket, final PipeSchemaRegionWritePlanEventBatch
batch)
+ throws PipeException, IOException {
+ final org.apache.iotdb.commons.queryengine.plan.planner.plan.node.PlanNode
planNode =
Review Comment:
Addressed in f2e6bf9c13a. Imported PlanNode instead of using the
fully-qualified name, and the batch transfer path now passes the cached
serialized PlanNode body into PipeTransferPlanNodeReq for air-gap transfer as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
