CritasWang commented on PR #114: URL: https://github.com/apache/iotdb-extras/pull/114#issuecomment-5029456069
Thanks for the PR! Two requests before we move forward with the review: 1. **Please try switching the backend from the REST API to [apache/iotdb-client-go](https://github.com/apache/iotdb-client-go)** — see the discussion in apache/iotdb#18258 (comment by @HTHou). The native client should perform better than REST, and the latest release (v2.0.8) already provides table-model support (`TableSession` / `PooledTableSession`). It would also give us typed values directly instead of decoding JSON and coercing `interface{}` (the `UseNumber` / `toInt64` workarounds in `table_query.go`), and the server-side `rest_query_default_row_size_limit` cap would no longer apply. 2. **Please also modernize the frontend build toolchain in this effort** — the plugin still builds with `@grafana/toolkit` (pinned to `latest` in `package.json`), which has been deprecated and archived by Grafana. The recommended path is migrating to `@grafana/create-plugin`. If that makes this PR too large, it's fine to do it as an immediate follow-up PR, but we should not keep adding features on top of a dead toolchain for long. The frontend part of this PR (the new QueryEditor mode, macros, format/precision options) looks like it can stay mostly as-is regardless of which transport the backend uses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
