PDGGK commented on PR #114: URL: https://github.com/apache/iotdb-extras/pull/114#issuecomment-5030415673
Thanks @CritasWang @HTHou — done: the table-model backend now goes through [apache/iotdb-client-go](https://github.com/apache/iotdb-client-go) v2.0.8 (`TableSession`) instead of the REST API (bb4ffad). Notes on what the switch changed: - The native client connects to the **RPC port** rather than the REST port, so the datasource gained an optional `rpc address` setting; when left empty the plugin uses the URL's host with the default port 6667. Sessions come from a lazily created per-datasource `TableSessionPool`, so datasources that only use the tree model never open an RPC connection. Tree-model queries and the health check still use the REST service — moving those over is probably best folded into the SDK/toolchain modernization. - Values now arrive as typed Go values, which removed the whole JSON `UseNumber`/`interface{}` coercion layer, and the client converts TIMESTAMP values with the server-reported timestamp precision. That also let me simplify the time macros: `$__timeFilter` / `$__timeFrom` / `$__timeTo` now expand to ISO 8601 UTC literals (e.g. `2020-09-13T12:26:40.000+00:00`), which parse correctly under any server `timestamp_precision`, instead of epoch-ms integers. - The per-query database is applied with `USE` on the pooled session; DATE/BLOB render the same as before (`yyyy-MM-dd` / `0x…` hex). And as you said, the REST row cap no longer applies — the README now recommends a `LIMIT` clause for wide scans. - The stale "column-major" comments Copilot flagged went away with the rewrite. On the toolchain: I'll take the `@grafana/toolkit` → `@grafana/create-plugin` migration as the immediate follow-up PR, as suggested — that keeps this one reviewable on its own. It's also the natural place for the remaining frontend bot notes (Jest coverage for the new mode, and the pre-existing QueryEditor props-mutation / state-update patterns CodeQL flags), since the editor code gets reworked there anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
