CritasWang commented on PR #114: URL: https://github.com/apache/iotdb-extras/pull/114#issuecomment-5055083611
Both points look good to me. The `verifyQuery` fix is correct: requiring the database means every table-model query always runs `USE <database>` on its checked-out session, so there is no path by which a session's leftover state from a previous query can influence a result — regardless of pool scheduling or how many panels share the datasource. The comment in the code explains the reasoning clearly. The smoke-test caveat (backend path only, not through a rendered Grafana panel) is acceptable given the agreed toolchain situation. The scenarios you covered — multi-database pool sharing, all-types round-trip including INT64 above 2^53, ISO-8601 macro expansion on a live server, error surfacing — are exactly what matters for this PR. The in-Grafana screenshot can follow with the toolchain-migration PR as discussed. LGTM from my side. Waiting for CI on the latest commit to go green, then this is ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
