Caideyipi commented on PR #19019:
URL: https://github.com/apache/iotdb/pull/19019#issuecomment-6416127534

   Self-review passed after fixing one confirmed issue in 
[0afdbd51dbd](https://github.com/apache/iotdb/commit/0afdbd51dbd917755267fdc963e1d4b92c852044).
 No further actionable findings remain from this pass through the complete PR 
diff and the related subscription lifecycle and recovery code.
   
   **[P2] Release the previous parsed-tablet snapshot before retained 
redelivery.** At the [reviewed 
revision](https://github.com/apache/iotdb/blob/de91065d91fe302b19773629ca1b561171d77bf1/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/event/SubscriptionEvent.java#L330-L334),
 resetting a downloaded, uncommitted tablet delivery rewound its batch but left 
the iteration snapshot already transferred into 
`SubscriptionPipeTabletBatchEvents` alive. The next completed download replaced 
that snapshot without cleanup, leaving parsed-tablet memory allocated even 
after the final ACK and event cleanup. The fix releases the old delivery 
snapshot before rewinding, without acknowledging the uncommitted data.
   
   The new regression uses a real TsFile, checks row contents across an initial 
download and two redeliveries, then verifies that final ACK/cleanup returns 
tablet memory to its original baseline.
   
   Validation:
   
   - **Reproduced before the fix:** on `de91065d91f` plus the new regression, 
final ACK/cleanup still left **1342 bytes** allocated, versus an expected 
baseline of **0**.
   - **PASS:** 119 focused unit tests across 14 suites, with 0 failures, errors 
or skips, including the real-TsFile regression and the related replay, broker, 
receiver, metadata and procedure tests.
   - **PASS:** EN ConfigNode/DataNode dependency reactor through `test`. 
DataNode and ConfigNode were cleaned before the final run. Unchanged upstream 
outputs were reused only from this review's clean source build with matching 
toolchain, profile and compiler options; all required IoTDB dependencies were 
built from source in this round, with build-output caches disabled.
   - **PASS:** clean 29-module ZH ConfigNode/DataNode dependency reactor 
through `test-compile`, with tests not run.
   - **PASS:** `mvn spotless:apply -P with-integration-tests` scoped to the 
affected tablet classes, and `git diff --check`. Verification ran locally.
   - **NOT RUN:** feature ITs, live-cluster restart recovery and the full 
repository/distribution build on this fix. Apache still hardcodes 
`SUBSCRIPTION_ENABLED = false`; the previously reported IT failures with status 
1912 do not validate the feature. CI results for the newly pushed commit have 
not been assessed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to