Caideyipi commented on PR #19019:
URL: https://github.com/apache/iotdb/pull/19019#issuecomment-6436708737

   Re-review passed after fixing one confirmed lifecycle issue in 
[PipeHeartbeatParser.java:196](https://github.com/apache/iotdb/blob/e9c9fab5475d6601232faa421700d506ac548317/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeatParser.java#L196).
 A retained finite snapshot subscription pipe with no matching DataRegions has 
no DataNode task queue that can report completion, so it could remain 
indefinitely and never emit the terminal response on resubscription. The 
completion predicate now permits the empty-required-region case while 
preserving the reliable-report gate and existing removal/notification path. The 
regression is covered by 
[PipeHeartbeatParserTest.java:694](https://github.com/apache/iotdb/blob/e9c9fab5475d6601232faa421700d506ac548317/iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeatParserTest.java#L694).
   
   Validation: `mvn spotless:apply -P with-integration-tests -pl 
iotdb-core/confignode` and `git diff --check` passed. The targeted 
`PipeHeartbeatParserTest` did not run to completion: the remote clean reactor 
stalled resolving a JitPack POM, and the local clean reactor failed during 
`iotdb-consensus` test compilation because Windows could not reserve 1.8 GiB 
for a Surefire JVM under the available system commit limit. The new regression 
therefore remains unverified by execution.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to