Caideyipi commented on PR #19019: URL: https://github.com/apache/iotdb/pull/19019#issuecomment-6440722211
Re-review passed after fixing one confirmed snapshot-retention lifecycle issue in [b13f7acbea7](https://github.com/apache/iotdb/commit/b13f7acbea76f3b1bc230e8aa7f31b8002a407ad). A retained finite snapshot with no matching DataRegions has no region task queue that can report its completion. The completion decision therefore must survive loss of local broker state and metadata recovery; otherwise a later resubscription can recreate the Pipe and cross the original empty-snapshot boundary. ConfigNode now persists the empty-snapshot completion marker after a reliable DataNode report. DataNode metadata replay clears tasks added after that boundary and restores broker completion after both single-pipe updates and full recovery. Regression coverage exercises tree/table mode, unsubscribe/rejoin, broker and task-agent recovery, and reusing the recovered Pipe on resubscription. I found no further actionable findings in the current diff. Validation: - Surefire reports: `PipeHeartbeatParserTest#testParseHeartbeatCompletesRetainedSnapshotSubscriptionPipeWithoutDataRegions`, `CreateSubscriptionProcedureTest#testResubscribeReusesRecoveredCompletedEmptySnapshot`, and `SubscriptionRetainedInitialReplayTest#testEmptyRetainedSnapshotCompletionSurvivesRejoinAndBrokerRecovery` each ran 1 test with 0 failures, errors, or skips. - The latter two tests ran in a clean 29-module dependency reactor. Maven printed `BUILD SUCCESS`, but remained alive after the summary and was interrupted; I cannot report a clean shell exit status. - Spotless apply reported all three affected modules clean with 0 files changed and printed `BUILD SUCCESS`; its process also remained alive after the summary and was interrupted. `git diff --check` passed. - Feature integration tests, a live-cluster DataNode restart, and the full distribution build were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
