Caideyipi commented on PR #19023:
URL: https://github.com/apache/iotdb/pull/19023#issuecomment-6432780601

   Self-review passed at 
[72494ee3e40](https://github.com/apache/iotdb/commit/72494ee3e4063d71c3680a7b80798b533ae518b0)
 after reviewing the complete diff and the related commit batching, provider 
recovery, server ACK handling, and consumer lifecycle paths. All confirmed 
review findings are fixed.
   
   Fixed **[P2] Whole-group retries replay completed RPC batches** in 
[`AbstractSubscriptionConsumer.java:1588`](https://github.com/apache/iotdb/blob/72494ee3e4063d71c3680a7b80798b533ae518b0/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumer.java#L1588)
 and 
[`AbstractSubscriptionProvider.java:816`](https://github.com/apache/iotdb/blob/72494ee3e4063d71c3680a7b80798b533ae518b0/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java#L816).
 A DataNode group can span multiple RPCs. If a later RPC lost its connection, 
the earlier responses were discarded and the whole group was retried, replaying 
accepted ACKs, retaining confirmed contexts after retry exhaustion, or hiding 
an earlier rejection. Completed results now preserve accepted contexts and 
checkpoint progress; retries send only the unconfirmed suffix, and an earlier 
rejection prevents automatic 
 retry.
   
   Validation:
   
   - Added three regression methods covering completed-batch replay, 
accepted-context/checkpoint retention after exhaustion, and rejection followed 
by a connection failure. All three failed before the fix and passed afterward.
   - A clean 11-module dependency reactor passed on a remote JDK 17 host with 
two Maven threads, an isolated Maven repository, sanitized global/user 
settings, and build-cache reuse disabled. All **50 tests passed**, including 
the original six new methods and these three additions. Checkstyle and Spotless 
passed. The tested sources match the pushed commit.
   - Local `mvn spotless:apply -P with-integration-tests -pl 
iotdb-client/subscription` and `git diff --check` passed. Unit tests ran 
remotely; local tests and the original long-running workload remain unrun.
   
   Focused test selection (with the isolated repository and sanitized settings 
also supplied):
   
   ```sh
   ./mvnw -T 2 clean test -pl iotdb-client/subscription -am -P 
with-integration-tests \
     
-Dtest=SubscriptionConsumerMultiProviderPollTest,SubscriptionConsumerLifecycleTest,SubscriptionProviderConnectionTimeoutTest,SubscriptionProviderSlicingTest
 \
     -Dsurefire.failIfNoSpecifiedTests=false
   ```
   
   The original head's SonarCloud quality gate was failing; the 50 GitHub 
annotations inspected were outside this PR's diff and were left unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to