Caideyipi commented on PR #19023:
URL: https://github.com/apache/iotdb/pull/19023#issuecomment-6434670946

   Re-review found and fixed one additional P2 issue in 
[c87de548bbb](https://github.com/apache/iotdb/commit/c87de548bbb1f060d01d280476af57ad3e9fc729).
   
   When file or tablet continuation polling failed, the cleanup NACK could 
itself hit a transient `SubscriptionConnectionException`. That cleanup failure 
escaped the original poll error, so a recoverable provider outage could be 
reported as a critical failure and leave the event in flight until the server 
lease/recovery path returned it. This affected 
[`AbstractSubscriptionConsumer.java:1066`](https://github.com/apache/iotdb/blob/c87de548bbb1f060d01d280476af57ad3e9fc729/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumer.java#L1066)
 and 
[`AbstractSubscriptionConsumer.java:1275`](https://github.com/apache/iotdb/blob/c87de548bbb1f060d01d280476af57ad3e9fc729/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumer.java#L1275).
   
   The cleanup path now retries transient NACK connection failures through the 
same bounded provider-recovery loop, waiting outside the provider read lock. 
Fencing and server-side errors still propagate immediately; after retry 
exhaustion, the original non-critical poll failure remains the outcome and the 
cleanup failure is retained as suppressed. Ordinary explicit NACKs keep their 
existing behavior. Regression coverage was added in 
[`SubscriptionConsumerMultiProviderPollTest.java:595`](https://github.com/apache/iotdb/blob/c87de548bbb1f060d01d280476af57ad3e9fc729/iotdb-client/subscription/src/test/java/org/apache/iotdb/session/subscription/consumer/base/SubscriptionConsumerMultiProviderPollTest.java#L595)
 and 
[`SubscriptionConsumerMultiProviderPollTest.java:631`](https://github.com/apache/iotdb/blob/c87de548bbb1f060d01d280476af57ad3e9fc729/iotdb-client/subscription/src/test/java/org/apache/iotdb/session/subscription/consumer/base/SubscriptionConsumerMultiProviderPollTest.java#L631).
   
   Validation:
   
   - Clean remote JDK 17 validation built TsFile from source commit 
`eb733133b9eee0b1eb74f7671d809ecd730cedc3`, then ran the IoTDB 11-module 
dependency reactor.
   - **53 tests passed, 0 failures, 0 errors, 0 skipped**, including all 
`SubscriptionConsumerMultiProviderPollTest` regressions. Checkstyle and 
Spotless passed.
   - Local `mvn spotless:apply -P with-integration-tests -pl 
iotdb-client/subscription` and `git diff --check` passed; local unit tests were 
not run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to