Caideyipi commented on PR #19023: URL: https://github.com/apache/iotdb/pull/19023#issuecomment-6435719194
Re-review of the complete diff at `4bbeedd2952` and the related ACK, continuation-poll, and lifecycle paths is complete. Two additional P2 issues are fixed in [b86ea0926b4](https://github.com/apache/iotdb/commit/b86ea0926b498b6f23f5de4c73bb88d984894bc4): - **Delayed completed-batch results could still roll back a newer concurrent checkpoint** — [`AbstractSubscriptionConsumer.java:1607`](https://github.com/apache/iotdb/blob/4bbeedd29529807804d2d30208e5e0445a2e1cf3/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumer.java#L1607), with the replacement at [line 2257](https://github.com/apache/iotdb/blob/4bbeedd29529807804d2d30208e5e0445a2e1cf3/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumer.java#L2257). If one batch succeeds, a later RPC blocks, and another provider commits newer progress before that RPC loses its connection, the completed result is first applied *after* the newer commit. Applying each result once did not prevent this ordering: the regression moved one writer from sequence `2` back to `1` and discarded another writer's checkpoint. ACK results now merge monotonically per writer, preserving concurrent progress. Explicit seeks retain their existing ability to move backward. - **A later server error discarded earlier successful ACK batches** — [`AbstractSubscriptionProvider.java:815`](https://github.com/apache/iotdb/blob/4bbeedd29529807804d2d30208e5e0445a2e1cf3/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java#L815). Completed results were preserved only for connection exceptions. A subsequent server rejection or fencing response therefore left already accepted contexts pending and omitted their returned checkpoint, allowing subsequent flushes to replay confirmed ACKs. Completed results now survive server exceptions across synchronous, asynchronous, automatic, close-time, and redirected ACKs. The original exception identity/type and consumer fencing are preserved; server errors are not retried. Automatic commits also remove confirmed results before propagating an error that prevents returning their removable-context set. Validation: - All **six new regression methods failed against `4bbeedd2952`** with the expected context-retention or checkpoint-rollback assertions, then passed with the fix. Server-error coverage includes non-critical errors, critical errors, owner fencing, and consumer fencing across all five ACK paths. - Remote JDK 17 clean **11-module source reactor: 63 tests passed, 0 failures, 0 errors, 0 skipped**, covering `SubscriptionConsumerMultiProviderPollTest`, `SubscriptionConsumerLifecycleTest`, `SubscriptionProviderConnectionTimeoutTest`, and `SubscriptionProviderSlicingTest`. A separate clean Chinese-locale `test-compile` of the same dependency reactor also passed. Checkstyle and Spotless passed. - Both builds used two Maven threads, an isolated repository, sanitized global/user settings, and disabled build caches. Required TsFile dependencies were rebuilt from source `eb733133b9eee0b1eb74f7671d809ecd730cedc3`, with only Maven coordinates adapted to `2.5.1-261023-SNAPSHOT`; installed JAR hashes matched the source build. Third-party download caches were reused. Tested source hashes match the pushed commit. - Local `mvn spotless:apply -P with-integration-tests -pl iotdb-client/subscription` and `git diff --check` passed. Local unit tests and the original long-running workload were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
