Caideyipi commented on PR #19019: URL: https://github.com/apache/iotdb/pull/19019#issuecomment-6450085459
Fresh independent review completed for PR #19019 at the current head `dc4fabe851885e326450ab92ce4b137375ad8a04` (the previously expected head was `4d4c3c52f32bb756e4ce86d6152eaff33facd2fd`; the current PR contains the additional recovery commit). The base is `6b77a8dc8f000b9117f2c7b250b5ed97a680e89b`. I reviewed the complete 33-file base-to-head diff (2,606 additions and 104 deletions), surrounding implementation and tests, and the existing PR comments. I found no new actionable issue, so no code change, commit, or push was needed in this review. The current history preserves the `root.__system` access isolation from the base, and I did not repeat issues already documented as fixed in earlier comments. The review covered snapshot retention creation, ownership, release and lifecycle boundaries; unsubscribe/resubscribe; empty snapshots and no-DataRegion completion; DataNode/ConfigNode recovery; rollback, failure, exception and repeated-call paths; serialization and persistence; concurrency and resource lifecycle; and retained broker/queue/in-flight event state. Validation: - **PASS:** `mvn -o -pl iotdb-core/datanode -Dtest=SubscriptionRetainedInitialReplayTest,SubscriptionConsumerAgentTest -Dsurefire.failIfNoSpecifiedTests=false -Ddevelocity.off=true -DforkCount=0 test` - 16 tests passed (9 + 7), with 0 failures, errors, or skips. Maven printed `BUILD SUCCESS`, but the process did not exit naturally and was terminated by the outer runner after the result was emitted. - **PASS:** `mvn -o -pl iotdb-core/confignode -Dtest=PipeHeartbeatParserTest#testParseHeartbeatCompletesRetainedSnapshotSubscriptionPipeWithoutDataRegions,CreateSubscriptionProcedureTest,DropTopicProcedureTest,AlterTopicProcedureTest,SubscriptionInfoTest,DropSubscriptionProcedureTest,DropConsumerProcedureTest -Dsurefire.failIfNoSpecifiedTests=false -Ddevelocity.off=true -DforkCount=0 test` - 36 tests passed (1 + 6 + 5 + 5 + 13 + 4 + 2), with 0 failures, errors, or skips. Maven printed `BUILD SUCCESS`, but again did not exit naturally and was terminated by the outer runner after the result was emitted. - **PASS:** `git diff --check 6b77a8dc8f000b9117f2c7b250b5ed97a680e89b...dc4fabe851885e326450ab92ce4b137375ad8a04`. - **NOT PASSED:** `mvn -o -pl iotdb-core/confignode,iotdb-core/datanode,iotdb-core/node-commons -DskipTests -Ddevelocity.off=true spotless:check` failed during Maven processing of `node-commons` before the Spotless goal ran; Spotless is therefore not claimed as passed. Not run in this review: the full reactor/distribution build, integration tests, live-cluster DataNode restart recovery, and CI/Sonar. The existing automated Sonar Quality Gate comment remains separate from this code review. **Conclusion: full independent review passed with no new findings and no requested code changes.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
