Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6598304450
Independent re-review of the P1 SessionPool capacity recovery addition, reviewed at `339f1074518b0a611f86f9a094250b62a8e86942` against `24fd30e1ac6b43a32aaeca2066034b1ae81fbc44`. Two actionable findings were fixed in `SessionPoolIT.java`: - The failed-write path did not cover an interrupted capacity wait in `getSession()`. The existing scenario now holds the sole session, observes a real wait on the pool monitor, interrupts the borrower, returns the held session, and checks the preserved interrupt flag, worker completion, reuse of the same Session, exact data, capacity counts, and cleanup. It reuses the same pool and cluster. - The 1-second connection setting also limits RPC reads. A workstation run timed out on the first healthy write while initial schema/DataRegion/TsFile creation was still in progress. The RPC and borrow deadlines are now 30 seconds; write retries remain disabled. Validation: Spotless, whitespace checks, and IT source selection passed. A local Windows/JDK 17 clean 37-module reactor built all prerequisites but reproduced the 1-second timeout error. A subsequent Maven attempt stopped before the IT because the shared TsFile cache contained a corrupt JAR. The final test source was independently compiled and run through a focused JUnit method request with the same Cluster1 properties, source-built IoTDB jars/node templates, and isolated valid copies of the packaged external dependencies: **1 test, 0 failures, 0 errors, 0 skipped; exit 0**. The log confirms the `InterruptedException` branch was executed. This final result is a workstation JUnit result; it is not a passing Maven reactor or CI result. This round's remote preparation attempts did not execute the IT, and CI for the final head remains unchecked. The concurrently published metadata-test commit `8fdf070a2cc12653d2f1c3d7da4babe22c40f787` was preserved by rebasing the unpublished fix. The P1 file is identical to tested snapshot `8b35204a1e9770ddbd02da240902f3ec4f2514bf`. Final local, source branch, and PR heads were confirmed equal at **`986e23a1d46a595896ed8168ba5cdf35eb3475a6`**. The PR remains **draft** pending a fresh independent P1 re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
