Caideyipi commented on PR #19063: URL: https://github.com/apache/iotdb/pull/19063#issuecomment-6570628411
Initial self-review round: reviewed the complete 19-file diff and relevant context at `343708dba8b5fc52cf79fa4d8cbc0511f01e5467`. Found and fixed one P2 cancellation issue in `IoTDBAirGapReceiver.handleReq`: an interrupted temporary-unavailable retry restored the interrupt flag and recursively retried. Shutting down the ordered UDP consumer could therefore reenter request handling repeatedly. The fix preserves interruption and throws `InterruptedIOException` to terminate the retry. The regression requires exactly one receiver invocation, preserves the interrupt flag, and checks that no ACK or NACK is emitted. Final local commit and confirmed remote branch/PR head: `358020e0a4a476660d144ce6398ff3ecc989e90d`. The fix has been committed and pushed. Verification: - The earlier handshake, buffering, and pacing snapshot passed 49 selected tests. After the final cancellation fix, all 13 receiver tests passed, including the new regression, with no failures, errors, or skips. - English and Chinese compilation passed for the changed modules and their transitive dependencies. Spotless apply and whitespace checks passed. - The final package passed two-node Linux realtime and gzip-compressed historical transfers with reverse traffic blocked. Each scenario verified all 512,000 values in 8,000 rows. Both windows had six initial handshakes, zero receiver-directory deletions, zero slice/order/checksum failures, and zero UDP socket-drop increments. The historical case used the default 5 ms per-Pipe sink interval. - Local executable tests were not run. The checks above ran on the two verification hosts. GitHub CI is pending for the final commit. The PR remains draft because this round found a behavioral issue. A fresh independent review of the complete final diff is required before marking it ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
