Caideyipi commented on code in PR #19063:
URL: https://github.com/apache/iotdb/pull/19063#discussion_r4439889893
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/airgap/IoTDBAirGapReceiverAgent.java:
##########
@@ -54,12 +58,17 @@ public class IoTDBAirGapReceiverAgent implements IService {
private static final int UDP_PACKET_MAX_SIZE_IN_BYTES = 65_507;
private static final int UDP_SESSION_CLEANUP_INTERVAL_MS = 60_000;
private static final int UDP_MAX_CLIENT_SESSIONS = 1_024;
- private static final int LISTENER_THREAD_COUNT = 2;
+ private static final int LISTENER_THREAD_COUNT = 3;
+ private static final int UDP_REQUEST_QUEUE_CAPACITY = 4_096;
+ private static final int UDP_REQUEST_QUEUE_BYTES = 32 * 1024 * 1024;
Review Comment:
The new property only controls the kernel socket receive buffer. The copied
application queue remains fixed at 4,096 packets and 32 MiB, and the sender UDP
packet-size and request-slice settings do not configure these limits. Could we
expose the queue bounds through receiver configuration, or explicitly confirm
that they are intentionally fixed? As written, receive buffering cannot be
tuned end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]