Caideyipi commented on PR #19063: URL: https://github.com/apache/iotdb/pull/19063#issuecomment-6571105451
Independent re-review round: reviewed the complete 19-file PR diff and relevant context at `358020e0a4a476660d144ce6398ff3ecc989e90d`, including the previous cancellation fix. No actionable issues affecting source behavior or test logic were confirmed. No code changes, new commits, or pushes were needed. The review covered repeated-handshake authentication and state reuse, partial files and pending slices, compressed and sliced request context, bounded UDP buffering and ordered consumption, shutdown interruption, ACK/NACK suppression, configuration scope, and compatibility with the acknowledged transports. The comparison merge base is `3a51384b2dcc8c29118b7d082c829450c4408b4c`; the current target branch tip is `999721fcafd5e95ff5f3de931ad34175ea315946`. Relevant intervening target changes were inspected without modifying the PR branch. Verification: this was a read-only review. Existing recorded receiver tests, English/Chinese compilation, and realtime/compressed-history transfer evidence were inspected. Builds and executable tests were not rerun, as requested. Local HEAD and the confirmed source-branch/PR head are all `358020e0a4a476660d144ce6398ff3ecc989e90d`. GitHub CI is separate from this review approval and is not fully green. DataNode unit tests on Linux and Windows, dependency checks, and Chinese compilation completed successfully. SonarCloud Code Analysis reports a failed quality gate; its annotations cover equality, complexity, style, and other static-analysis suggestions. The Windows table-standalone shard failed at `IoTDBCurrentQueriesIT.testMoreConfigurations:248` (expected 1 finished query, observed 6), outside the changed code and tests. The cause was not established or changed in this round; follow-up CI investigation remains necessary. Other jobs were still running when inspected. This complete round meets the independent-review gate. Immediately before marking ready, the local commit, source branch, and PR head were rechecked and still matched the reviewed SHA. The ready transition succeeded and returned `isDraft=false` at that same commit. Remote CI remains a separate, incomplete gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
