Caideyipi commented on PR #19098:
URL: https://github.com/apache/iotdb/pull/19098#issuecomment-6594778679

   Initial independent self-review (one round): reviewed the full diff against 
`master` (`e6b44b57e49e1e7f0ecf5d6c62fa7e1f69a9a869`) and the relevant schema, 
LOAD analysis, and automatic-loader context.
   
   **[P2] Preserve wrapped region-unavailable errors.** At the reviewed 
revision, 
[TreeSchemaAutoCreatorAndVerifier.java:311](https://github.com/apache/iotdb/blob/ecbf4150d72031399d7336eb66409cac09a603e3/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/TreeSchemaAutoCreatorAndVerifier.java#L311)
 only inspected the top-level exception. [Template 
activation](https://github.com/apache/iotdb/blob/ecbf4150d72031399d7336eb66409cac09a603e3/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/AutoCreateSchemaExecutor.java#L612)
 can wrap status 906 in `SemanticException(IoTDBException)`, so LOAD still 
returned 1100 and moved a recoverable file to the failed directory. Fixed by 
preserving 906 through the cause chain, with transient and permanent-error 
regression controls.
   
   Validation:
   
   - Before the repair, the wrapped transient regression failed with expected 
1110 versus actual 1100; the permanent-error control passed.
   - After the repair, a clean dependency reactor passed all 20 relevant unit 
tests: 10 diagnostics, 7 loader, and 3 handler tests, with no failures, errors, 
or skips. All 482 goals executed. Spotless passed. All newly added tests were 
run locally.
   - The earlier two-method 1C3D integration run passed at the reviewed SHA; it 
was not repeated after this repair. The full test suite and Chinese-locale 
build were not run locally.
   - CI for the final SHA is pending. The earlier Sonar reliability failure 
points to `java:S3078` in unchanged `PipeTaskInfo.java:1174`; that report is 
outside this PR's diff and remains unverified here.
   
   Reviewed SHA: `ecbf4150d72031399d7336eb66409cac09a603e3`  
   Final local SHA: `e5e2b2767b9c1b9483bd2287732e4c62eca24c1f`  
   Confirmed source branch and PR head SHA: 
`e5e2b2767b9c1b9483bd2287732e4c62eca24c1f`
   
   The repair was committed and pushed to 
`apache/iotdb:fix/load-scanner-restart` after refreshing the remote head. All 
update steps are complete. The PR remains Draft because this round found a 
behavioral issue and requires a fresh independent review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to