Caideyipi commented on PR #19098:
URL: https://github.com/apache/iotdb/pull/19098#issuecomment-6594924571

   Re-review (one round): reviewed the complete diff against `master` 
(`e6b44b57e49e1e7f0ecf5d6c62fa7e1f69a9a869`) and the relevant schema 
activation, LOAD analysis, and active-loader paths, including the wrapped 
status-906 repair.
   
   No actionable findings. The cause-chain handling preserves 
`NO_AVAILABLE_REGION_GROUP` through the `SemanticException(IoTDBException)` 
path while permanent metadata errors remain non-retryable. The tests cover both 
wrapped outcomes and the direct LOAD-analysis status mapping.
   
   Validation:
   - The recorded clean dependency-reactor run passed all 20 relevant unit 
tests (10 diagnostics, 7 loader, 3 handler). All added tests ran locally; 
Spotless passed.
   - The two 1C3D integration tests passed on the preceding reviewed SHA 
(`ecbf4150d72031399d7336eb66409cac09a603e3`) and were not rerun after this 
repair. The full local test suite and Chinese-locale build were not run locally.
   - Final-SHA CI is incomplete: `zh-locale-compile` passed, one `Simple (17)` 
job failed during `Set up job` before any test step ran, and other checks were 
pending when checked. No overall CI pass is claimed.
   
   Reviewed SHA: `e5e2b2767b9c1b9483bd2287732e4c62eca24c1f`
   Final local SHA: `e5e2b2767b9c1b9483bd2287732e4c62eca24c1f`
   Confirmed source branch and PR head SHA: 
`e5e2b2767b9c1b9483bd2287732e4c62eca24c1f`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to