Caideyipi commented on PR #19098:
URL: https://github.com/apache/iotdb/pull/19098#issuecomment-6598538648

   External-comment follow-up at `6ac971c08673bc50c382e64d6b67b790cf9d96ca`:
   
   - [Region availability 
question](https://github.com/apache/iotdb/pull/19098#discussion_r4452047056): 
clarified that 906 is an availability signal and cannot distinguish recovery 
from persistent region loss. The file is retained for retry in either case; 
persistent loss needs operator intervention. The two misleading/incomplete Java 
comments were clarified, with no behavior change.
   - [Sonar 
report](https://github.com/apache/iotdb/pull/19098#issuecomment-6594911632): 
the reported reliability issue is `java:S3078` in `PipeTaskInfo.java:1174`. 
That file is unchanged by this PR, so the report is left for a separate fix; no 
unrelated change is included here.
   - [Codecov 
report](https://github.com/apache/iotdb/pull/19098#issuecomment-6595260455): 
the report shows 61.90476% patch coverage and eight uncovered analyzer lines. 
The existing diagnostics exercise direct/wrapped schema failures and the 
single-file analysis retry path, with permanent-error controls. Their earlier 
passing run is recorded in the preceding validation summaries. This follow-up 
adds no executable lines, and no coverage improvement or green coverage gate is 
claimed.
   
   Validation: `mvn spotless:apply -P with-integration-tests -pl 
iotdb-core/datanode` passed with exit code 0. This update changes only Java 
comments; compilation and tests were not repeated, and no tests were added. CI 
for the new head has not been awaited.
   
   Follow-up starting SHA: `e5e2b2767b9c1b9483bd2287732e4c62eca24c1f`  
   Final local SHA: `6ac971c08673bc50c382e64d6b67b790cf9d96ca`  
   Confirmed source branch and PR head SHA: 
`6ac971c08673bc50c382e64d6b67b790cf9d96ca`
   
   The clarification is committed and pushed. All discussions are left 
unresolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to