Caideyipi commented on PR #18623: URL: https://github.com/apache/iotdb/pull/18623#issuecomment-6597103519
Completed one review round against `79d0f87719117fc2539e6177e91696acae89a0ef`. Fixes are pushed through `cd15321de564b63a270ad7e5cc517c7c3a98c544`; local HEAD, the source branch, and the PR head were confirmed equal. - Fixed the continuous-table IT failure seen in [the multi-cluster job](https://github.com/apache/iotdb/actions/runs/41575322865/job/125717356536). `ClusterTestResultSet.next()` throws when `SHOW PIPE` temporarily returns different visibility across DataNodes, so the original Awaitility condition stopped instead of waiting. The condition now checks every node independently and continues only when all nodes see the Pipe. SQL/connection errors and the existing capture/restore assertions remain effective. - Hardened ZIP extraction staging: temporary directories now live under `user.home`, with explicit owner-only permissions on POSIX filesystems and inherited home-directory ACLs elsewhere. Added a location/permissions regression test. - Reused a lazily initialized `SecureRandom` and aligned the IT with the default-credential helpers and test-user password requirements. Validation on Windows with JDK 17: - Spotless apply and `git diff --check` passed. - `PipeLogicalBackupToolTest`: 17 tests passed. - Ten affected unit-test classes across Node Commons, DataNode, and ConfigNode: 96 tests passed. - Clean dependency-reactor `verify` with `IoTDBPipeLogicalBackupIT`, `MultiClusterIT2DualTreeManual`, and two `HighPerformanceMode` clusters (1 ConfigNode + 3 DataNodes each): both tests passed. - All reported test runs had zero failures, errors, or skips. All tests newly added by this PR have run locally on Windows. The clean IT reactor rebuilt the required IoTDB modules with the local task cache disabled. The supplemental unit run reused that same source build. Existing third-party dependency caches were used. Remote verification could not start because source fetching failed with a TLS handshake error; the POSIX-only permission assertions have not been executed. CI for the final head is still in progress. The PR remains draft pending a fresh independent review of the updated full diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
