Caideyipi commented on PR #18623: URL: https://github.com/apache/iotdb/pull/18623#issuecomment-6624621285
Completed one independent re-review of the full 52-file diff and relevant context at `8dc0f37c5d072284ef46bf9be431d3e7c7afa246`, against `master/e6b44b57e49e1e7f0ecf5d6c62fa7e1f69a9a869`. No new actionable source-behavior or test-logic findings; no fixes, commits or pushes were needed. The review included Schema/Config snapshot staging reconstruction, checkpoint preservation across repeated interruptions, request-specific idempotent replay permission, acknowledged-seal boundaries, and the corrected Config seal fixture against the actual receiver contract. It also covered the earlier ZIP permissions, random generation, per-node waits, credentials, Windows paths, exclude-all filtering, event UUID generations, and writer rollback/sealing/rollover paths. Local verification in this round: - A clean CLI + ConfigNode dependency reactor passed: 31 modules, 533 goals, 130 unit tests, zero failures/errors/skips. This includes CLI 22, writer 30, archive reader 17, settings 2, non-DataRegion source 5, DataNode sink 8, subtask manager 5, realtime source 4, ConfigNode sink 2, Config constructor 1, Config Thrift requests 10, and heartbeat parser 24. - Windows, JDK 17.0.15, Maven 3.8.8, English message sources, one Maven thread. All required IoTDB dependencies were rebuilt from clean source; existing third-party caches were used. No subscription override. This was a focused reactor check, not an uncached full build. - Reactor formatting, Checkstyle and forbidden-API checks, `git diff --check`, and en/zh key and placeholder parity for all 116 new message constants passed. - POSIX-only permission assertions, dual-cluster ITs, full-process restart/leader-failover scenarios, and a full zh-locale build were not run this round. Mock receiver tests do not establish full-process recovery. Earlier test results remain historical. CI, refreshed at 2026-11-04 06:50:10 UTC, remains separate from these local results: **39 successful checks, 2 failures, 1 in progress; combined status pending**. [SonarCloud](https://github.com/apache/iotdb/runs/126400341948) still reports Reliability Rating D (A required). [Simple (17)](https://github.com/apache/iotdb/actions/runs/41775817396/job/126395791731) reports 3,281 tests, 0 assertion failures, 1 error and 66 skipped. The error is `IoTDBLoadTsFileActiveScanIT.testIncompletePublicationSurvivesScannerRestartAndPreservesMods:106 -> awaitRows:235`, timing out while awaiting data. That file is outside this PR diff; the root cause remains unconfirmed. These CI failures have not been resolved. Final local HEAD, the actual source branch `apache/iotdb:feat/pipe-logical-backup-sink`, and the PR head all match **`8dc0f37c5d072284ef46bf9be431d3e7c7afa246`**. After reconfirming the unchanged head, the PR was marked Ready; REST verified **open, draft=false** at 06:50:32 UTC. The local round record was written before this summary. This session performed only this one review round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
