Caideyipi commented on PR #18623: URL: https://github.com/apache/iotdb/pull/18623#issuecomment-6598859005
Independent re-review completed for `bc38d803580d1bf73ec15231bafdab746d88ba2e` against `master` at `e6b44b57e49e1e7f0ecf5d6c62fa7e1f69a9a869`. The full current diff and related context were inspected. Two behavioral findings were fixed and pushed: - **P2 — Honor table exclude-all filters.** At [LogicalBackupDumpOptions.java:215](https://github.com/apache/iotdb/blob/bc38d803580d1bf73ec15231bafdab746d88ba2e/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/pipe/LogicalBackupDumpOptions.java#L215), `--model table --exclude '.*/.*'` skipped both exclusion clauses and captured everything selected by the inclusion. Apply an exclusion when the opposite dimension is unrestricted, including when both dimensions are unrestricted. Added coverage for whole-database, whole-table, and exclude-all filters, with and without an explicit inclusion. Fixed in `0b6b0060f6b74bb8edb6bdcadd89b4d18c409aff`. - **P1 — Namespace event IDs across task/process lifetimes.** At [DataNode LogicalBackupSink.java:514](https://github.com/apache/iotdb/blob/bc38d803580d1bf73ec15231bafdab746d88ba2e/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/logicalbackup/LogicalBackupSink.java#L514) and [ConfigNode LogicalBackupSink.java:177](https://github.com/apache/iotdb/blob/bc38d803580d1bf73ec15231bafdab746d88ba2e/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/sink/protocol/logicalbackup/LogicalBackupSink.java#L177), IDs used commit counters that reset when a task is recreated. Appending to its existing stream could silently discard a new event as a duplicate, fail with a different-digest error, or create repeated IDs rejected during archive verification. Include a process-wide UUID and the committer generation while keeping IDs stable for retries within the same generation. Added DataNode and ConfigNode archive round-trip tests for equal and diffe rent payloads after task recreation, including repeated delivery. Fixed in `09bd6c2bf03c25d9824aad8e1a455948450e58ad`. Validation: - Before the fixes, the two CLI regressions failed, and the DataNode task-recreation tests reproduced both silent deduplication and a different-digest error. - All 19 CLI tests passed after the filter fix. A clean dependency-reactor build then passed 49 archive/writer/sink tests (22 writer, 17 reader, 8 DataNode sink, 2 ConfigNode sink), with no failures, errors, or skips. Windows/JDK 17, English locale; all newly added tests ran locally. - The Windows launcher quoting at `scripts/tools/windows/logical-backup.bat:23–24` passed packaged CLI `--help` smoke checks from an installation path containing spaces and `&`: main launcher, both aliases, and explicit `IOTDB_HOME`, all exit 0. All three Bash launchers passed `bash -n`. - Spotless and `git diff --check` passed. The PR description was corrected to remove a claim about a documentation file absent from the diff. - The previous ZIP staging, SecureRandom, per-node wait, and credential fixes yielded no additional confirmed findings. The earlier 113 unit tests and 2 dual-cluster ITs are historical results and were not rerun as a complete suite this round. POSIX permission assertions and full process-restart/leader-failover IT scenarios remain unexecuted. The event-ID fix preserves delivery retry identity; it does not establish exactly-once source replay across process restarts. - Remote test setup timed out fetching source before Maven started. An initial local attempt hit a dependency JAR read error; a bounded diagnostic succeeded, and subsequent clean verification completed. No remote test pass is claimed. Final local HEAD, source branch `apache/iotdb:feat/pipe-logical-backup-sink`, and PR head are confirmed equal: `09bd6c2bf03c25d9824aad8e1a455948450e58ad`. Worktree clean; PR remains open and **Draft** because this round found behavioral issues. A fresh independent round is required before Ready. CI snapshot for the final SHA: 38 checks observed, 2 in progress and 36 queued; combined commit status pending. These are not passing CI results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
