Caideyipi commented on PR #18623: URL: https://github.com/apache/iotdb/pull/18623#issuecomment-6623988769
Independent re-review at `e8f181cdf51e6bc9d70781d301cdd6ac16976202` found a test-logic gap in the Config snapshot resume fixtures: they relabeled Schema requests without constructing Config-specific seal metadata, so they did not validate the Config protocol contract. The CLI fixture now builds and asserts the required Config file and plan-type metadata and exercises the acknowledged-seal boundary for both Schema and Config. Before the fix, both focused regressions failed because the Config `fileType` was absent (`expected 4, got null`). Local verification: the clean 30-module CLI dependency reactor and all 22 CLI tests passed (0 failures, errors or skips); Spotless and `git diff --check` passed. Remote CI is separate: at final head `8dc0f37c5d072284ef46bf9be431d3e7c7afa246`, 39 of 41 completed checks succeeded; SonarCloud Code Analysis failed the Reliability Rating gate (D, required A), and Simple (17) failed with one Integration-Test error among 3,281 tests (66 skipped; availabl e summaries do not identify its cause). One check remains queued and combined status is pending. Reviewed SHA: `e8f181cdf51e6bc9d70781d301cdd6ac16976202`. Final local HEAD, source-branch head and PR head all match `8dc0f37c5d072284ef46bf9be431d3e7c7afa246`. The PR remains open/Draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
