Caideyipi commented on code in PR #19161:
URL: https://github.com/apache/iotdb/pull/19161#discussion_r4509084972
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##########
@@ -2535,9 +2534,6 @@ public synchronized void loadHotModifiedProps() throws
QueryProcessException {
ConfigurationFileUtils.releaseDefault();
}
reloadMetricProperties(commonProperties);
- if (wasReadOnlyForDiskFull) {
- commonConfig.setRunningIfDiskFull();
Review Comment:
[P2] Refresh non-tier data-directory recovery checks on reload
With this clearing step removed, checks from ordinary FolderManagers also
survive a successful reload, but only TierManager checks follow the new
configuration. For example,
SnapshotLoader.createLinksFromSnapshotDirToDataDirWithoutLog() constructs a
plain FolderManager from getLocalDataDirs(). If construction fails while the
old data disk is full, DirectoryStrategy.setFolders() registers a callback over
List.copyOf(oldDirs). After dn_data_dirs adds a free disk, new tier and
snapshot-loading managers can use that disk, while the discarded snapshot
manager's callback still checks only the full old disk. Even after the
aggregate disk-space check passes, tryRecoverFromDiskFull() therefore keeps the
whole DataNode in ReadOnly(DiskFull). Please refresh or retire checks owned by
these reloadable data-directory consumers as well, while preserving independent
sources such as WAL. A regression should cover failed snapshot-manager
construction, adding a free data directory through reload, an
d subsequent heartbeat recovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]