hongzhi-gao commented on code in PR #19161:
URL: https://github.com/apache/iotdb/pull/19161#discussion_r4510844637


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##########
@@ -2535,9 +2534,6 @@ public synchronized void loadHotModifiedProps() throws 
QueryProcessException {
       ConfigurationFileUtils.releaseDefault();
     }
     reloadMetricProperties(commonProperties);
-    if (wasReadOnlyForDiskFull) {
-      commonConfig.setRunningIfDiskFull();

Review Comment:
   Thanks, good catch. Fixed in cfd1dce455f: SnapshotLoader, LoadStagingDirs, 
and LoadUtil now check their current configured directories for DiskFull 
recovery, while independent sources such as WAL remain registered. The new 
SnapshotLoaderDiskFullReloadTest covers failed snapshot FolderManager 
construction, adding a writable data directory, and the heartbeat recovery 
check (tryRecoverFromDiskFull). It also verifies that an unavailable WAL source 
still keeps the node ReadOnly. The focused tests passed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to