hongzhi-gao commented on code in PR #19161:
URL: https://github.com/apache/iotdb/pull/19161#discussion_r4510846053


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java:
##########
@@ -251,21 +298,31 @@ private void mkDataDirs(List<String> folders) {
 
   public String getNextFolderForTsFile(int tierLevel, boolean sequence)
       throws DiskSpaceInsufficientException {
-    return sequence
-        ? seqTiers.get(tierLevel).getNextFolder()
-        : unSeqTiers.get(tierLevel).getNextFolder();
+    return getFolderManager(tierLevel, sequence).getNextFolder();
   }
 
   public String getNextFolderForCopyToTargetFile() throws 
DiskSpaceInsufficientException {
-    return copyToFolderManager.get().getNextFolder();
+    return getFolderManager(0, 
IoTDBConstant.COPY_TO_TARGET_FOLDER_NAME).getNextFolder();
   }
 
   public String getNextFolderForObjectFile() throws 
DiskSpaceInsufficientException {
-    return objectTiers.get(0).getNextFolder();
+    return getFolderManager(0, 
IoTDBConstant.OBJECT_FOLDER_NAME).getNextFolder();
+  }
+
+  public FolderManager getFolderManager(int tierLevel, boolean sequence)
+      throws DiskSpaceInsufficientException {
+    String folderName =
+        sequence ? IoTDBConstant.SEQUENCE_FOLDER_NAME : 
IoTDBConstant.UNSEQUENCE_FOLDER_NAME;
+    return getFolderManager(tierLevel, folderName);
   }
 
-  public FolderManager getFolderManager(int tierLevel, boolean sequence) {
-    return sequence ? seqTiers.get(tierLevel) : unSeqTiers.get(tierLevel);
+  private FolderManager getFolderManager(int tierLevel, String folderName)
+      throws DiskSpaceInsufficientException {
+    TierFolderManager entry = folderManagers.get(new TierDirectory(tierLevel, 
folderName));
+    if (entry == null) {
+      throw new IndexOutOfBoundsException(tierLevel);
+    }

Review Comment:
   Updated in cfd1dce455f. The missing-key exception now includes the 
TierDirectory key, whose message contains both tierLevel and folderName (for 
example, TierDirectory[tierLevel=2, folderName=sequence]). TierManagerTest 
asserts both values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to