Caideyipi commented on PR #19257:
URL: https://github.com/apache/iotdb/pull/19257#issuecomment-6851366044

   Fresh-session re-review passed at `1e67fa3c89aa1b5ea870445f4f3c88ae9caa5036` 
against the supplied base `9a281f8e1c062007233a89bd18a8e22372097fc2`. I 
inspected the complete 35-file diff and relevant JDBC and server cleanup 
context, including the previous repairs and the latest BigDecimal change. No 
new actionable source-behavior or test-logic issues were found; no fixes were 
needed.
   
   The deprecated BigDecimal overload now applies fractional-digit scaling with 
`RoundingMode.HALF_UP`, preserving SQL NULL handling and rejection of negative 
scales. The change remains within the requested bug-fix scope and excludes 
driver version/property metadata and new DataSource connection-property 
functionality.
   
   Verification and current limits:
   
   - Reused the recorded checks for the unchanged source: Spotless passed, and 
the latest-head clean reactor focused run passed in all 7 modules with 23 
ResultSet tests and all 115 goals executed without build-cache reuse. The local 
Surefire report confirms 23 tests with no failures, errors, or skips. All newly 
added unit tests were already run locally; this read-only round did not repeat 
them. Remote Maven verification remains incomplete; local integration tests 
were not run.
   - The captured CI snapshot has 35 successful checks, 1 failure, 1 queued 
check, and 2 skipped checks. The failed [Simple (17) 
job](https://github.com/apache/iotdb/actions/runs/43398566880/job/131795411739) 
timed out in 
`IoTDBLoadTsFileClusterIT.testRestartedDataNodeIsSyncedWithTheLoadedFile`, 
observing 2 of 3 expected local replicas. No causal link to this PR was 
established. CI was not awaited.
   - Live `master` has advanced to `ed9504f3aeb8cef403b736dd773f95091b2acad9`. 
A merge-tree check confirms a conflict in 
[IoTDBLoadTsFileIT.java:419-423](https://github.com/apache/iotdb/blob/1e67fa3c89aa1b5ea870445f4f3c88ae9caa5036/integration-test/src/test/java/org/apache/iotdb/relational/it/db/it/IoTDBLoadTsFileIT.java#L419-L423):
 retain the target's per-method `database` variable together with this PR's 
`oldTableDescription` snapshot. The branch was not synced in this round; this 
conflict still prevents merging.
   
   Reviewed SHA, final local SHA, fork branch, and PR head were all verified 
equal at `1e67fa3c89aa1b5ea870445f4f3c88ae9caa5036`. After checking that the 
head was unchanged, the PR was marked **ready for review** and read back as 
open/non-draft. No commits or pushes were made. This session performed exactly 
one review round; the approval applies to the supplied snapshot.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to