Caideyipi commented on PR #19257:
URL: https://github.com/apache/iotdb/pull/19257#issuecomment-6846686375

   Initial independent self-review completed at 
`0e500a05aef651e1f38615a154beeba2491c8a33` against `apache/iotdb:master` 
(`9a281f8e1c062007233a89bd18a8e22372097fc2`). I inspected the complete 35-file 
target diff and relevant code context. This session performed one review round.
   
   Two findings were fixed:
   
   1. **[P2] Use the correct query path for client-side table prepared 
statements.** 
[IoTDBTablePreparedStatement.java:206-208](https://github.com/apache/iotdb/blob/0e500a05aef651e1f38615a154beeba2491c8a33/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBTablePreparedStatement.java#L206-L208)
 always invoked the server-prepared execution path. With the newly calculated 
parameter count, calling `executeQuery()` on a parameterized non-query 
statement dereferenced null parameter arrays instead of reporting a 
`SQLException`; client-side `SHOW VERSION` also used an unprepared server 
statement. The fix completes client-side SQL and uses the existing ordinary 
query RPC, retaining prior-result cleanup and server error/status propagation.
   2. **[P3] Preserve malformed-host bracket validation.** 
[Utils.java:71-76](https://github.com/apache/iotdb/blob/0e500a05aef651e1f38615a154beeba2491c8a33/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/Utils.java#L71-L76)
 dropped the previous rejection of misplaced brackets in non-bracketed 
authorities, accepting URLs such as `jdbc:iotdb://localhost]:6667`. The bracket 
guard is restored, preserving the existing IPv6 path.
   
   The diff remains limited to bug fixes and tests: no driver version/property 
metadata additions or new DataSource connection-property support.
   
   Validation:
   
   - Three new regression tests reproduced the failures before the production 
fixes; all passed after the fixes.
   - Spotless passed with the integration-test formatting profile.
   - Clean English reactor test run for JDBC and its dependencies passed: **236 
JDBC tests and 119 service-rpc tests**, no failures, errors, or skips.
   - Clean Chinese-locale reactor `test-compile` for JDBC and its dependencies 
passed. Both final builds disabled compilation-cache reuse and rebuilt the 
required IoTDB modules from source.
   - `git diff --check` passed. Integration-test execution was not run. All 
newly added unit tests were run locally.
   
   Final local commit, fork branch 
`Caideyipi/iotdb:codex/jdbc-bugfix-17865-pr`, and PR head were verified equal 
at `14646a152301006c99059637f76b95c74d27668f`. The update was a normal 
fast-forward push after checking draft status and both remote heads. The PR 
remains **draft** because this round found behavioral issues; a fresh-session 
review is required. No second review was started in this session. Remote CI was 
queued/running at verification and was not awaited.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to