Caideyipi commented on PR #19257: URL: https://github.com/apache/iotdb/pull/19257#issuecomment-6847212998
Re-review of PR #19257 completed at `14646a152301006c99059637f76b95c74d27668f` against `apache/iotdb:master` (`9a281f8e1c062007233a89bd18a8e22372097fc2`). I inspected the complete 35-file diff and relevant JDBC context; this was the only review round in this session. One behavioral finding was fixed: [IoTDBPreparedStatement.java:101](https://github.com/apache/iotdb/blob/14646a152301006c99059637f76b95c74d27668f/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBPreparedStatement.java#L101) derived the bind count from a scanner that treated `?` inside backtick-quoted identifiers as a parameter. This made `ParameterMetaData.getParameterCount()` incorrect and caused parameter indices and SQL substitution to shift. The scanner now skips quoted strings, identifiers, and comments; a regression test verifies the count and completed SQL. The fix was committed as `df5f11e6f81d13f82406901dd6a69d9cc322ab25` and pushed to `Caideyipi/iotdb:codex/jdbc-bugfix-17865-pr`. The final local commit, fork branch, and PR head were verified equal at that SHA. The PR remains **draft** because this round found a behavioral issue; a fresh-session re-review is required. Validation: - `mvn spotless:apply -P with-integration-tests -pl iotdb-client/jdbc -Ddevelocity.off=true` passed. - Clean reactor test of `IoTDBPreparedStatementTest`: 26 tests, 0 failures, errors, or skips; dependencies were rebuilt from source. - The broader English JDBC/service-rpc tests (236/119) and Chinese clean reactor `test-compile` passed earlier on the reviewed parent `14646a152301006c99059637f76b95c74d27668f`; they were not rerun after this focused follow-up. - Integration-test execution was not run; CI was not awaited. All newly added unit tests were run locally. - No driver version/property metadata or new DataSource connection-property feature was added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
