Dan Burkert has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions ......................................................................
Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/3648/14/src/kudu/client/client.h File src/kudu/client/client.h: Line 775: /// Add a range partition to the table with an inclusive lower bound and > For doxygen comments, it's necessary to start one-line comment line with 3 Done Line 778: /// @note The table alterer takes ownership of the rows. > It's just a matter of formatting, but I would add extra 2 spaces in the beg Done Line 780: /// @note Multiple range partitions may be added as part of a single alter > Does 'logical minimum' turns into 'logical maximum' for upper_bound? no, still minimum. Done. Line 806: /// partition exactly, and may not span multiple range partitions. > Ditto: please clarify on 'logical minimum value' for upper_bound and consid We're consistent on logical minimum for both upper and lower bounds everywhere that partition bounds are used. Logical maximum is impossible for the string data type. -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
