Adar Dembo has posted comments on this change. Change subject: tool: better handling for positional arguments ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4013/3/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: Line 145: const boost::optional<vector<string>>& variadic_args) const { > why an optional vector instead of just an empty vector inthe case that ther Done -- To view, visit http://gerrit.cloudera.org:8080/4013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6aa517ccf1915e4d106bcc5f80a3abfeae03271 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
