Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL ......................................................................
KUDU-1571. Generate "deprecated" metrics in MDL This checks in the "--dump_metrics_json" output from already-released versions, and changes the generate_mdl.py script so that any metrics which were ever present in an earlier version are carried through to the current version of the MDL, but marked as deprecated. This works around an issue in which Cloudera Manager doesn't properly handle the removal of metrics. Namely, if a dashboard (user-generated or built-in) references a removed metric, it will produce an NPE. This will now become part of the release process: after a release, we should check in the output of 'dump_metrics_json' so that the metrics in that release will be carried forward. I verified the results using both the newly included 'check_csd_compatibility' script as well as installing a newly built 0.10.x CSD on a cluster. Whereas the tablet server status page was previously broken, now it shows the remote bootstrap metrics as DEPRECATED. Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Reviewed-on: http://gerrit.cloudera.org:8080/4067 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <mpe...@apache.org> (cherry picked from commit 062996ad7d1c3aa90cd9ea5ec11b73dc17e085d6) Reviewed-on: http://gerrit.cloudera.org:8080/4075 Reviewed-by: Todd Lipcon <t...@apache.org> Tested-by: Todd Lipcon <t...@apache.org> --- M build-support/release/rat_exclude_files.txt A java/kudu-csd/check_csd_compatibility.py M java/kudu-csd/generate_mdl.py A java/kudu-csd/old-version-metrics/0.10.0-master.json A java/kudu-csd/old-version-metrics/0.10.0-tserver.json A java/kudu-csd/old-version-metrics/0.9.1-master.json A java/kudu-csd/old-version-metrics/0.9.1-tserver.json 7 files changed, 4,831 insertions(+), 17 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
