Adar Dembo has posted comments on this change. Change subject: Convert pbc-dump over to the new tool infrastructure ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4037/1/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: PS1, Line 63: "path" > yea, it's a kind of quirk of the tool infrastructure. Optional arguments co I chose to highlight the "required vs. optional" nature of the parameters, but we can certainly change it to "positional vs. key-value" if you guys think that's more important. I don't have a strong opinion either way. -- To view, visit http://gerrit.cloudera.org:8080/4037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
