Adar Dembo has posted comments on this change.

Change subject: [docs] added Kudu version into the doxygen footer
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4165/1/CMakeLists.txt
File CMakeLists.txt:

PS1, Line 79: execute_process(COMMAND git rev-parse HEAD
            :   WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
            :   OUTPUT_VARIABLE KUDU_SRC_GIT_HASH)
What happens if this runs outside of a git repo, or if git isn't installed? 
Some of our builds don't work directly against git.

Also, I think it would be better if we could rely on version_defines.h (see 
util/CMakeLists.txt) for this information instead of generating it again.


http://gerrit.cloudera.org:8080/#/c/4165/1/docs/support/doxygen/client_api.doxy.in
File docs/support/doxygen/client_api.doxy.in:

PS1, Line 55: share/doc/kuduClient/samples/sample.cc
Can we substitute this in as a list? Better yet if we can somehow set it from 
within src/kudu/client/CMakeLists.txt, which is where sample.cc is placed in 
the installation output.


http://gerrit.cloudera.org:8080/#/c/4165/1/docs/support/doxygen/client_api.footer.in
File docs/support/doxygen/client_api.footer.in:

PS1, Line 6: </body>
           : </html>
Presumably these were opened in the header?


http://gerrit.cloudera.org:8080/#/c/4165/1/src/kudu/client/shared_ptr.h
File src/kudu/client/shared_ptr.h:

PS1, Line 21: /// @file shared_ptr.h
Hmm, I don't recall seeing @file tags in the other files you doxygenized. What 
is its purpose here?


PS1, Line 22: pointers
Nit: pointer


PS1, Line 39: defined(__clang__)
You can build Kudu with gcc on macOS? Didn't know that was possible.


-- 
To view, visit http://gerrit.cloudera.org:8080/4165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3861aafa1e615cc991647704d9a4ce8d44ad678f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to