Alexey Serbin has posted comments on this change.

Change subject: [docs] added Kudu version into the doxygen footer
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4165/1/CMakeLists.txt
File CMakeLists.txt:

PS1, Line 79: execute_process(COMMAND git rev-parse HEAD
            :   WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
            :   OUTPUT_VARIABLE KUDU_SRC_GIT_HASH)
> I didn't know that: was assuming all builds work against git-cloned repo.  
After some consideration I think adding git hash from version_defines.h 
deserves a separate commit.  For now it will be just sem-version, no git hash 
info in the doxygen footer.


-- 
To view, visit http://gerrit.cloudera.org:8080/4165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3861aafa1e615cc991647704d9a4ce8d44ad678f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to