Todd Lipcon has posted comments on this change. Change subject: compaction_policy: fix bound calculation ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4152/1/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: PS1, Line 160: fractional_solution_ > Nit: why not to use priority_queue for that as a handy wrapper? good point, although in the next patch I'll need to actually access all the non-top elements of the heap, and priority_queue<> doesn't seem to let you access non-top elements without popping. PS1, Line 161: >= > So, if the resulting weight is equal to the specified max_weight, then it's Done -- To view, visit http://gerrit.cloudera.org:8080/4152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76364c17debd7293b36884d64c7747f8c604ae12 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward #174 Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
