Todd Lipcon has posted comments on this change. Change subject: compaction_policy: fix bound calculation ......................................................................
Patch Set 2: The tests in the next commit actually catch this bug. If I revert this patch and run the test from "Optimize budgeted compaction policy with an approximation" it fails with: ../../src/kudu/tablet/compaction_policy-test.cc:112: Failure Expected: (total_size) <= (budget_mb), actual: 144 vs 128 -- To view, visit http://gerrit.cloudera.org:8080/4152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76364c17debd7293b36884d64c7747f8c604ae12 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #174 Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: No
