David Ribeiro Alves has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4154/1//COMMIT_MSG Commit Message: Line 16: the server side. A corresponding commit on the JS side adds a slight question: don't we need both of these commits together to avoid breaking pulling the trace? Line 18: version uses base64) nit: missing period http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/server/tracing-path-handlers.cc File src/kudu/server/tracing-path-handlers.cc: Line 125: Status ZlibCompress(const string& input, stringstream* out) { maybe move this to some util place (don't feel strongly about it) PS1, Line 262: kEndRecordingCompressed oh, I see, we support both compressed and decompressed, so it won't break anything, is that it? http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: Line 166: string ZlibUncompress(const faststring& compressed) { yeah, seems like if we have both compress and decompress this could be in util/ no? -- To view, visit http://gerrit.cloudera.org:8080/4154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
