Todd Lipcon has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/server/tracing-path-handlers.cc File src/kudu/server/tracing-path-handlers.cc: PS3, Line 270: /tracing/json/end_recording_compressed > Does it make sense to rely on Content-Encoding HTTP header field instead? yea, I briefly considered that, but the way the web handler functions are currently registered, there's not actually any access to either retrieve or set any headers. I didn't want to scope-creep a small patch into redoing how web pages are registered/handled, so went with the "dumb" thing here. (also following what the upstream Chrome code does) http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/util/zlib.h File src/kudu/util/zlib.h: Line 22: #include "kudu/util/status.h" > nit: consider including the header with Slice definition (kudu/util/slice.h woops, will address these in a follow-up -- To view, visit http://gerrit.cloudera.org:8080/4154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
