Alexey Serbin has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/server/tracing-path-handlers.cc File src/kudu/server/tracing-path-handlers.cc: PS3, Line 270: /tracing/json/end_recording_compressed Does it make sense to rely on Content-Encoding HTTP header field instead? https://en.wikipedia.org/wiki/HTTP_compression I.e., compress the output regarding whether the HTTP client accepts gzipped content? http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/util/zlib.h File src/kudu/util/zlib.h: PS3, Line 20: #include <string> Is it really needed? Line 22: #include "kudu/util/status.h" nit: consider including the header with Slice definition (kudu/util/slice.h ?) -- To view, visit http://gerrit.cloudera.org:8080/4154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
