Adar Dembo has posted comments on this change.

Change subject: c++ client: expose private GetTablet API
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4179/1/src/kudu/client/client.h
File src/kudu/client/client.h:

Line 351:   /// Private API.
> is it possible to get doxygen to not document this?
I'll add a tag to force doxygen to ignore this. I'm inclined to punt on the 
snipping, at least until we have more private APIs.


Line 362:                                   KuduTablet** tablet);
> if we had the 'NO_DISTRIBUTE' type thing then we could use unique_ptr here 
Not easily, because we'd still need to #include <memory> somewhere, and that 
would need to get excised too (since TR1 has it in tr1/memory).


-- 
To view, visit http://gerrit.cloudera.org:8080/4179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If798820e5d790d07f554aaa6f89b31aaf360a3a5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to