Todd Lipcon has posted comments on this change. Change subject: c++ client: expose private GetTablet API ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4179/1/src/kudu/client/client.h File src/kudu/client/client.h: Line 351: /// Private API. is it possible to get doxygen to not document this? I also wonder whether we could do something by which the installed client.h that comes as part of the dev package snips this out? (eg via a // NO_DISTRIBUTE .. // END_NO_DISTRIBUTE marker or something) Line 362: KuduTablet** tablet); if we had the 'NO_DISTRIBUTE' type thing then we could use unique_ptr here for the out-param -- To view, visit http://gerrit.cloudera.org:8080/4179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If798820e5d790d07f554aaa6f89b31aaf360a3a5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
