Adar Dembo has submitted this change and it was merged. Change subject: c++ client: expose private GetTablet API ......................................................................
c++ client: expose private GetTablet API The new API can be used to look up tablet information (i.e. replicas and roles) using a tablet ID. I'm going to use it in kudu-admin; the "change config" operation needs to know which tserver hosts the tablet's leader replica. Without this new API, we'd have to go through the scan token API, which means either forcing the user to also provide the table name, or abusing the scan token API by creating tokens for _all_ tables, then hunting for the matching tablet. As such, I've opted to make this API "private". I've done so via KUDU_NO_EXPORT, though I could have just as easily declared it a private method and used friendship. This way it can more easily be tested (as tests do not use the "exported" client library). Change-Id: If798820e5d790d07f554aaa6f89b31aaf360a3a5 Reviewed-on: http://gerrit.cloudera.org:8080/4179 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/client/client-internal.cc M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h 4 files changed, 141 insertions(+), 9 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If798820e5d790d07f554aaa6f89b31aaf360a3a5 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
