Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4180/3/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: Line 384: .AddAction(std::move(delete_table)) I'm a little unconvinced about mixing "physical"/"operator" type operations like ksck and the various consensus tweak tools with "logical" operations like list and delete tables. How do you feel about a separate 'kudu table {delete,list,...}' which is the kind of thing that a regular user might want to use, separate from the special operator tools that live here? -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
