Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' ......................................................................
Patch Set 4: (2 comments) didn't really look at the implementation because I assume that's just moved code and boilerplate, and imagine it's fine. But I still am -1 on some of the organizational stuff, and nervous about "we'll clean it up later" given this is a public API and we are counting the days to 1.0.0rc0 in single digits http://gerrit.cloudera.org:8080/#/c/4180/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: PS4, Line 116: "cluster", : "change_config", : "add_server", repeating my earlier comment that I don't think this grouping of commands makes sense. This sounds like you are "changing the configuration of the cluster to add a server" which is not at all what's happening. I think 'kudu tablet change_config' or 'kudu tablet add_replica' or something would make a lot more sense what's going on. Line 182: "delete_table", still think "kudu table delete" and "kudu table list" would be more sensical, but this one isn't as egregious as the change_config one above. -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
