Andrew Wong has posted comments on this change.

Change subject: Inlined dispatch for predicate evaluation
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4164/2//COMMIT_MSG
Commit Message:

Line 6: 
line width: 70


http://gerrit.cloudera.org:8080/#/c/4164/2/src/kudu/common/column_predicate.h
File src/kudu/common/column_predicate.h:

Line 142:   bool EvaluateCell(DataType physical_type, const void *cell) const;
> I think you may want to define this method in the header, so that you can b
Will try out the public instantiations as discussed this morning.


-- 
To view, visit http://gerrit.cloudera.org:8080/4164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccfac9bc899362b442337050795b5ca8c4101268
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to