Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/2//COMMIT_MSG Commit Message: > Does it make sense to add some unit tests for the new methods/functions? O The behavior is covered by tablet-decoder-eval-test, which exercise EvaluateCell for dictionary and plain encoding. Currently, the non-BINARY branches are not used and not tested, since decoder-level evaluation is only supported right now for dictionary/plain encoding (both BINARY), so it may be worth testing those branches (or maybe taking them out). -- To view, visit http://gerrit.cloudera.org:8080/4164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccfac9bc899362b442337050795b5ca8c4101268 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
